From becd02ee30408a66d6d2e833ec3efd542b608a56 Mon Sep 17 00:00:00 2001 From: Arnaud Patard Date: Fri, 10 Nov 2006 01:52:34 +0200 Subject: [PATCH] dsp_fbexport: use kzalloc The dsp_export function calls omapfb_register_client() right after allocating the memory with kmalloc. A commit added to omapfb_register_client() a check on the value of plane_idx in the notified block structure. As we're only using kmalloc, you may end-up comparing garbage/random values (It even leads to a oops on my n770). Using kzalloc() fixes the issue. Signed-off-by: Arnaud Patard Signed-off-by: Tony Lindgren --- arch/arm/plat-omap/dsp/dsp_mem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/plat-omap/dsp/dsp_mem.c b/arch/arm/plat-omap/dsp/dsp_mem.c index ac45fafaa5f..b53cdc7e1ba 100644 --- a/arch/arm/plat-omap/dsp/dsp_mem.c +++ b/arch/arm/plat-omap/dsp/dsp_mem.c @@ -1495,7 +1495,7 @@ static int dsp_fbexport(dsp_long_t *dspadr) #endif #ifdef CONFIG_FB_OMAP_LCDC_EXTERNAL - omapfb_nb = kmalloc(sizeof(struct omapfb_notifier_block), GFP_KERNEL); + omapfb_nb = kzalloc(sizeof(struct omapfb_notifier_block), GFP_KERNEL); if (omapfb_nb == NULL) { printk(KERN_ERR "omapdsp: failed to allocate memory for omapfb_nb!\n"); -- 2.41.1