From a9c62a18a291499d15a370d08771e781fbaf91e6 Mon Sep 17 00:00:00 2001 From: Alan Cox Date: Tue, 16 Oct 2007 23:30:22 -0700 Subject: [PATCH] fs: correct SuS compliance for open of large file without options The early LFS work that Linux uses favours EFBIG in various places. SuSv3 specifically uses EOVERFLOW for this as noted by Michael (Bug 7253) [EOVERFLOW] The named file is a regular file and the size of the file cannot be represented correctly in an object of type off_t. We should therefore transition to the proper error return code Signed-off-by: Alan Cox Cc: Theodore Tso Cc: Jens Axboe Cc: Arjan van de Ven Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- fs/gfs2/ops_file.c | 2 +- fs/ntfs/file.c | 2 +- fs/open.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/gfs2/ops_file.c b/fs/gfs2/ops_file.c index 7eb4b280ac6..bb11fd6752d 100644 --- a/fs/gfs2/ops_file.c +++ b/fs/gfs2/ops_file.c @@ -406,7 +406,7 @@ static int gfs2_open(struct inode *inode, struct file *file) if (!(file->f_flags & O_LARGEFILE) && ip->i_di.di_size > MAX_NON_LFS) { - error = -EFBIG; + error = -EOVERFLOW; goto fail_gunlock; } diff --git a/fs/ntfs/file.c b/fs/ntfs/file.c index c814204d4ea..6cd08dfdc2e 100644 --- a/fs/ntfs/file.c +++ b/fs/ntfs/file.c @@ -61,7 +61,7 @@ static int ntfs_file_open(struct inode *vi, struct file *filp) { if (sizeof(unsigned long) < 8) { if (i_size_read(vi) > MAX_LFS_FILESIZE) - return -EFBIG; + return -EOVERFLOW; } return generic_file_open(vi, filp); } diff --git a/fs/open.c b/fs/open.c index 044bfa891c9..cdbb94a9efc 100644 --- a/fs/open.c +++ b/fs/open.c @@ -1177,7 +1177,7 @@ asmlinkage long sys_vhangup(void) int generic_file_open(struct inode * inode, struct file * filp) { if (!(filp->f_flags & O_LARGEFILE) && i_size_read(inode) > MAX_NON_LFS) - return -EFBIG; + return -EOVERFLOW; return 0; } -- 2.41.1