From 4a76ef036ac415c28d1adbaf2b7a74040b84d4c2 Mon Sep 17 00:00:00 2001 From: Nick Piggin Date: Wed, 14 Feb 2007 12:36:32 +0100 Subject: [PATCH] [PATCH] mincore: fill in results properly Paper bag time. Thanks to Randy for noticing that I didn't actually assign 'present' to anything. Unfortunately my original patch passed the few simple test cases I gave it, purely by coincidence. Signed-off-by: Nick Piggin Signed-off-by: Linus Torvalds --- mm/mincore.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/mm/mincore.c b/mm/mincore.c index 9780097e381..9c1d0a426e9 100644 --- a/mm/mincore.c +++ b/mm/mincore.c @@ -125,6 +125,8 @@ static long do_mincore(unsigned long addr, unsigned char *vec, unsigned long pag #endif } } + + vec[i] = present; } pte_unmap_unlock(ptep-1, ptl); @@ -135,6 +137,9 @@ none_mapped: pgoff = linear_page_index(vma, addr); for (i = 0; i < nr; i++, pgoff++) vec[i] = mincore_page(vma->vm_file->f_mapping, pgoff); + } else { + for (i = 0; i < nr; i++) + vec[i] = 0; } return nr; -- 2.41.1