]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
nfsd: use static memory for callback program and stats
authorOlga Kornievskaia <aglo@citi.umich.edu>
Fri, 28 Mar 2008 20:04:56 +0000 (16:04 -0400)
committerJ. Bruce Fields <bfields@citi.umich.edu>
Wed, 23 Apr 2008 20:13:42 +0000 (16:13 -0400)
commitff7d9756b501744540be65e172d27ee321d86103
treed5f812aa7dd230e51f4b5e2d921692757f41b983
parent8774282c4cef82695ccca8bd09976de5d6e49610
nfsd: use static memory for callback program and stats

There's no need to dynamically allocate this memory, and doing so may
create the possibility of races on shutdown of the rpc client.  (We've
witnessed it only after adding rpcsec_gss support to the server, after
which the rpc code can send destroys calls that expect to still be able
to access the rpc_stats structure after it has been destroyed.)

Such races are in theory possible if the module containing this "static"
memory is removed very quickly after an rpc client is destroyed, but
we haven't seen that happen.

Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
fs/nfsd/nfs4callback.c