]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
signals: fix /sbin/init protection from unwanted signals
authorOleg Nesterov <oleg@tv-sign.ru>
Wed, 30 Apr 2008 07:53:03 +0000 (00:53 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Wed, 30 Apr 2008 15:29:37 +0000 (08:29 -0700)
commitfae5fa44f1fd079ffbed8e0add929dd7bbd1347f
tree8990ac958d29733cb61733ae69265472f5e1d13c
parent193191035ad6268db9f561e81e3474b8be89a5ba
signals: fix /sbin/init protection from unwanted signals

The global init has a lot of long standing problems with the unhandled fatal
signals.

- The "is_global_init(current)" check in get_signal_to_deliver()
  protects only the main thread. Sub-thread can dequee the fatal
  signal and shutdown the whole thread group except the main thread.
  If it dequeues SIGSTOP /sbin/init will be stopped, this is not
  right too. Note that we can't use is_global_init(->group_leader),
  this breaks exec and this can't solve other problems we have.

- Even if afterwards ignored, the fatal signals sets SIGNAL_GROUP_EXIT
  on delivery. This breaks exec, has other bad implications, and this
  is just wrong.

Introduce the new SIGNAL_UNKILLABLE flag to fix these problems.  It also helps
to solve some other problems addressed by the subsequent patches.

Currently we use this flag for the global init only, but it could also be used
by kthreads and (perhaps) by the sub-namespace inits.

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Acked-by: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Roland McGrath <roland@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
include/linux/sched.h
init/main.c
kernel/signal.c