]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
pxafb: introduce register independent LCD connection type for pxafb
authoreric miao <eric.miao@marvell.com>
Wed, 30 Apr 2008 07:52:22 +0000 (00:52 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Wed, 30 Apr 2008 15:29:31 +0000 (08:29 -0700)
commit84f43c308b73a6a12128288721a1007ba4f1a8da
tree650246aced2ea56899f11099846980eeae8885e6
parent2c42dd8ebdd92ad59d9a68f88f0e20ad9f45270a
pxafb: introduce register independent LCD connection type for pxafb

Reasons:

  1. straight forward: the name "LCD_COLOR_DSTN_16BPP" is much better
     than "LCCR0_Pas | LCCR0_Color | LCCR0_Dual"

  2. by defining LCD connection types as constants, it allows only
     valid possibilities

  3. by removing the dependency of register bits definitions, those
     can be later moved into the body of pxafb.c, instead of having
     a regs-lcd.h around

Currently, only lubbock, mainstone, zylonite and littleton have been
modified to support these types (see coming patches after this).
Other platforms are encouraged to change their way describing the
LCD controller connections.

Signed-off-by: eric miao <eric.miao@marvell.com>
Cc: "Antonino A. Daplas" <adaplas@pol.net>
Cc: Russell King <rmk@arm.linux.org.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/video/pxafb.c
include/asm-arm/arch-pxa/pxafb.h