]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
[BLOCK] Fix oops on removal of SD/MMC card
authorRussell King <rmk@dyn-67.arm.linux.org.uk>
Fri, 5 May 2006 16:57:52 +0000 (17:57 +0100)
committerRussell King <rmk+kernel@arm.linux.org.uk>
Fri, 5 May 2006 16:57:52 +0000 (17:57 +0100)
commit56cf6504fc1c0c221b82cebc16a444b684140fb7
tree95c74c06397dfe29081afb7a38ad6f1810e0704b
parentd98550e334715b2d9e45f8f0f4e1608720108640
[BLOCK] Fix oops on removal of SD/MMC card

The block layer keeps a reference (driverfs_dev) to the struct
device associated with the block device, and uses it internally
for generating uevents in block_uevent.

Block device uevents include umounting the partition, which can
occur after the backing device has been removed.

Unfortunately, this reference is not counted.  This means that
if the struct device is removed from the device tree, the block
layers reference will become stale.

Guard against this by holding a reference to the struct device
in add_disk(), and only drop the reference when we're releasing
the gendisk kobject - in other words when we can be sure that no
further uevents will be generated for this block device.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Acked-by: Jens Axboe <axboe@suse.de>
block/genhd.c