]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
sg: disable interrupts inside sg_copy_buffer
authorFUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Thu, 11 Sep 2008 16:35:39 +0000 (18:35 +0200)
committerJens Axboe <jens.axboe@oracle.com>
Thu, 11 Sep 2008 16:35:39 +0000 (18:35 +0200)
commit50bed2e2862a8f3a4f7d683d0d27292e71ef18b9
tree4de32d8495a5b79aae38948871abc65bb58d9d10
parent2dc75d3c3b49c64fd26b4832a7efb75546cb3fc5
sg: disable interrupts inside sg_copy_buffer

The callers of sg_copy_buffer must disable interrupts before calling
it (since it uses kmap_atomic). Some callers use it on
interrupt-disabled code but some need to take the trouble to disable
interrupts just for this. No wonder they forget about it and we hit a
bug like:

http://bugzilla.kernel.org/show_bug.cgi?id=11529

James said that it might be better to disable interrupts inside the
function rather than risk the callers getting it wrong.

Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
lib/scatterlist.c