]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
fix sparse, checkpatch warnings in OMAP2/3 PRCM/PM code
authorPaul Walmsley <paul@pwsan.com>
Wed, 7 May 2008 17:52:01 +0000 (11:52 -0600)
committerTony Lindgren <tony@atomide.com>
Fri, 9 May 2008 21:41:49 +0000 (14:41 -0700)
commit347df59f5d20fdf905afbc26b1328b0e28a8a01b
tree6bb35930bad36400d2b674160476448e08bd148b
parent5de869d6eaa74e6cf00891ea0257d129b5e88e50
fix sparse, checkpatch warnings in OMAP2/3 PRCM/PM code

Fix sparse & checkpatch warnings in OMAP2/3 PRCM & PM code.  This mostly
consists of:

- converting pointer comparisons to integers in form similar to
  (ptr == 0) to the standard idiom (!ptr)

- labeling a few non-static private functions as static

- tagging appropriate integer<->pointer casts with __force

- adding prototypes for *_init() functions in the appropriate header
  files, and getting rid of the corresponding open-coded extern
  prototypes in other C files

- renaming the variable 'sclk' in mach-omap2/clock.c:omap2_get_apll_clkin
  to avoid shadowing an earlier declaration

Clean up checkpatch issues.  This mostly involves:

- converting some asm/ includes to linux/ includes

- cleaning up some whitespace

- getting rid of braces for conditionals with single following statements

Also take care of a few odds and ends, including:

- getting rid of unlikely() and likely() - none of this code is particularly
  fast-path code, so the performance impact seems slim; and some of those
  likely() and unlikely() indicators are probably not as accurate as the
  ARM's branch predictor

- removing some superfluous casts

Signed-off-by: Paul Walmsley <paul@pwsan.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
12 files changed:
arch/arm/mach-omap2/clock.c
arch/arm/mach-omap2/clock.h
arch/arm/mach-omap2/clock24xx.c
arch/arm/mach-omap2/clockdomain.c
arch/arm/mach-omap2/cm.h
arch/arm/mach-omap2/pm.c
arch/arm/mach-omap2/powerdomain.c
arch/arm/mach-omap2/prcm.c
arch/arm/mach-omap2/prm.h
include/asm-arm/arch-omap/clock.h
include/asm-arm/arch-omap/powerdomain.h
include/asm-arm/arch-omap/prcm.h