]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
genirq: record trigger type
authorDavid Brownell <dbrownell@users.sourceforge.net>
Wed, 1 Oct 2008 21:46:18 +0000 (14:46 -0700)
committerIngo Molnar <mingo@elte.hu>
Thu, 2 Oct 2008 08:24:09 +0000 (10:24 +0200)
commit0c5d1eb77a8be917b638344a22afe1398236482b
tree57d57c9b270cc10428f818cfec9725a1344b78ce
parentd6d5aeb661fc14655c417f3582ae7ec52985d2a8
genirq: record trigger type

Genirq hasn't previously recorded the trigger type used by any given IRQ,
although some irq_chip support has done so.  That data can be useful when
troubleshooting.  This patch records it in the relevant irq_desc.status
bits, and improves consistency between the two driver-visible calls
affected:

 - Make set_irq_type() usage match request_irq() usage:
    * IRQ_TYPE_NONE should be a NOP; succeed, so irq_chip methods
      won't have to handle that case any more (many do it wrong).
    * IRQ_TYPE_PROBE is ignored; any buggy out-of-tree callers
      might need to switch over to the real IRQ probing code.
    * emit the same diagnostics (from shared utility code)

 - Their kerneldoc now reflects usage:
    * request_irq() flags include IRQF_TRIGGER_* to specify
      active edge(s)/level ... docs previously omitted that
    * set_irq_type() is declared in <linux/irq.h> so callers
      should use the (bit-equivalent) IRQ_TYPE_* symbols there

Also: adds a warning about shared IRQs that don't end up using the
requested trigger mode; and fix an unrelated "sparse" warning.

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Acked-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
kernel/irq/chip.c
kernel/irq/internals.h
kernel/irq/manage.c