]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
Revert "semaphore: fix"
authorLinus Torvalds <torvalds@linux-foundation.org>
Sun, 11 May 2008 03:43:22 +0000 (20:43 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Sun, 11 May 2008 03:43:22 +0000 (20:43 -0700)
commit00b41ec2611dc98f87f30753ee00a53db648d662
tree431f5019ce8dfd0f9c2b0e3816128dc4a34a49ff
parent39f004ba27fcd2431030a3bb3c949fa3f93fa4ca
Revert "semaphore: fix"

This reverts commit bf726eab3711cf192405d21688a4b21e07b6188a, as it has
been reported to cause a regression with processes stuck in __down(),
apparently because some missing wakeup.

Quoth Sven Wegener:
 "I'm currently investigating a regression that has showed up with my
  last git pull yesterday.  Bisecting the commits showed bf726e
  "semaphore: fix" to be the culprit, reverting it fixed the issue.

  Symptoms: During heavy filesystem usage (e.g.  a kernel compile) I get
  several compiler processes in uninterruptible sleep, blocking all i/o
  on the filesystem.  System is an Intel Core 2 Quad running a 64bit
  kernel and userspace.  Filesystem is xfs on top of lvm.  See below for
  the output of sysrq-w."

See

http://lkml.org/lkml/2008/5/10/45

for full report.

In the meantime, we can just fix the BKL performance regression by
reverting back to the good old BKL spinlock implementation instead,
since any sleeping lock will generally perform badly, especially if it
tries to be fair.

Reported-by: Sven Wegener <sven.wegener@stealer.net>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
kernel/semaphore.c