From: David S. Miller <davem@davemloft.net>
Date: Tue, 4 Oct 2005 00:37:27 +0000 (-0700)
Subject: [SUNSU]: Fix bogus locking in sunsu_change_mouse_baud()
X-Git-Tag: v2.6.14-rc4~57^2
X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=fdc657c66678551c7987dc23a78ae1a26251276f;p=linux-2.6-omap-h63xx.git

[SUNSU]: Fix bogus locking in sunsu_change_mouse_baud()

The lock is not held when calling this function, so we
shouldn't drop then reacquire it.

Based upon a report from Jim MacBaine.

Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/serial/sunsu.c b/drivers/serial/sunsu.c
index 5959e6755a8..656c0e8d160 100644
--- a/drivers/serial/sunsu.c
+++ b/drivers/serial/sunsu.c
@@ -518,11 +518,7 @@ static void sunsu_change_mouse_baud(struct uart_sunsu_port *up)
 
 	quot = up->port.uartclk / (16 * new_baud);
 
-	spin_unlock(&up->port.lock);
-
 	sunsu_change_speed(&up->port, up->cflag, 0, quot);
-
-	spin_lock(&up->port.lock);
 }
 
 static void receive_kbd_ms_chars(struct uart_sunsu_port *up, struct pt_regs *regs, int is_break)