From: Andrew Morton <akpm@linux-foundation.org>
Date: Fri, 13 Feb 2009 00:47:01 +0000 (-0800)
Subject: Documentation/connector/cn_test.c: don't use gfp_any()
X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=f82da723398ff18d49275a5f03de6cae5f592e8e;p=linux-2.6-omap-h63xx.git

Documentation/connector/cn_test.c: don't use gfp_any()

cn_test_timer_func() is a timer handler and can never use GFP_KERNEL -
there's no point in using gfp_any() here.

Also, use setup_timer().

Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/Documentation/connector/cn_test.c b/Documentation/connector/cn_test.c
index be7af146dd3..6977c178729 100644
--- a/Documentation/connector/cn_test.c
+++ b/Documentation/connector/cn_test.c
@@ -137,7 +137,7 @@ static void cn_test_timer_func(unsigned long __data)
 
 		memcpy(m + 1, data, m->len);
 
-		cn_netlink_send(m, 0, gfp_any());
+		cn_netlink_send(m, 0, GFP_ATOMIC);
 		kfree(m);
 	}
 
@@ -160,10 +160,8 @@ static int cn_test_init(void)
 		goto err_out;
 	}
 
-	init_timer(&cn_test_timer);
-	cn_test_timer.function = cn_test_timer_func;
+	setup_timer(&cn_test_timer, cn_test_timer_func, 0);
 	cn_test_timer.expires = jiffies + HZ;
-	cn_test_timer.data = 0;
 	add_timer(&cn_test_timer);
 
 	return 0;