From: Patrick McHardy <kaber@trash.net>
Date: Fri, 18 Apr 2008 06:19:55 +0000 (-0700)
Subject: [PKT_SCHED]: Fix datalen check in tcf_simp_init().
X-Git-Tag: v2.6.26-rc1~1138^2~4
X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=f5ba2d32170679eb9b7c251ac3d9687916a41c18;p=linux-2.6-omap-h63xx.git

[PKT_SCHED]: Fix datalen check in tcf_simp_init().

datalen is unsigned so it can never be less than zero,
but that's ok because the attribute passed to nla_len()
has been validated and therefore a negative return
value is impossible.

Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/sched/act_simple.c b/net/sched/act_simple.c
index fbde461b716..64b2d136c78 100644
--- a/net/sched/act_simple.c
+++ b/net/sched/act_simple.c
@@ -115,7 +115,7 @@ static int tcf_simp_init(struct nlattr *nla, struct nlattr *est,
 		return -EINVAL;
 
 	datalen = nla_len(tb[TCA_DEF_DATA]);
-	if (datalen <= 0)
+	if (datalen == 0)
 		return -EINVAL;
 
 	pc = tcf_hash_check(parm->index, a, bind, &simp_hash_info);