From: Ingo Molnar <mingo@elte.hu>
Date: Thu, 9 Aug 2007 09:16:45 +0000 (+0200)
Subject: sched: reorder update_cpu_load(rq) with the ->task_tick() call
X-Git-Tag: v2.6.23-rc3~73^2~59
X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=f1a438d813d416fa9f4be4e6dbd10b54c5938d89;p=linux-2.6-omap-h63xx.git

sched: reorder update_cpu_load(rq) with the ->task_tick() call

Peter Williams suggested to flip the order of update_cpu_load(rq) with
the ->task_tick() call. This is a NOP for the current scheduler (the
two functions are independent of each other), ->task_tick() might
create some state for update_cpu_load() in the future (or in PlugSched).

Signed-off-by: Ingo Molnar <mingo@elte.hu>
---

diff --git a/kernel/sched.c b/kernel/sched.c
index 72bb9483d94..4680f52974e 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -3298,9 +3298,9 @@ void scheduler_tick(void)
 	struct task_struct *curr = rq->curr;
 
 	spin_lock(&rq->lock);
+	update_cpu_load(rq);
 	if (curr != rq->idle) /* FIXME: needed? */
 		curr->sched_class->task_tick(rq, curr);
-	update_cpu_load(rq);
 	spin_unlock(&rq->lock);
 
 #ifdef CONFIG_SMP