From: Mark Fasheh Date: Thu, 19 Jul 2007 08:47:01 +0000 (-0700) Subject: Document ->page_mkwrite() locking X-Git-Tag: v2.6.23-rc1~472 X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=ed2f2f9b3ff8debdf512f7687b232c3c1d7d60d7;p=linux-2.6-omap-h63xx.git Document ->page_mkwrite() locking There seems to be very little documentation about this callback in general. The locking in particular is a bit tricky, so it's worth having this in writing. Signed-off-by: Mark Fasheh Cc: Nick Piggin Cc: David Howells Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/Documentation/filesystems/Locking b/Documentation/filesystems/Locking index 970c8ec1a05..91ec4b40ebf 100644 --- a/Documentation/filesystems/Locking +++ b/Documentation/filesystems/Locking @@ -512,13 +512,22 @@ prototypes: void (*close)(struct vm_area_struct*); struct page *(*fault)(struct vm_area_struct*, struct fault_data *); struct page *(*nopage)(struct vm_area_struct*, unsigned long, int *); + int (*page_mkwrite)(struct vm_area_struct *, struct page *); locking rules: - BKL mmap_sem + BKL mmap_sem PageLocked(page) open: no yes close: no yes fault: no yes nopage: no yes +page_mkwrite: no yes no + + ->page_mkwrite() is called when a previously read-only page is +about to become writeable. The file system is responsible for +protecting against truncate races. Once appropriate action has been +taking to lock out truncate, the page range should be verified to be +within i_size. The page mapping should also be checked that it is not +NULL. ================================================================================ Dubious stuff