From: Harvey Harrison <harvey.harrison@gmail.com>
Date: Sun, 27 Apr 2008 04:00:17 +0000 (-0700)
Subject: x86: !x & y typo in mtrr code
X-Git-Tag: v2.6.26-rc1~367^2~5
X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=e686d34156ef0e56b2ebec505b809018bc0dc73b;p=linux-2.6-omap-h63xx.git

x86: !x & y typo in mtrr code

As written, this can never be true.

Spotted by the Sparse checker.

Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---

diff --git a/arch/x86/kernel/cpu/mtrr/generic.c b/arch/x86/kernel/cpu/mtrr/generic.c
index 353efe4f501..5d241ce94a4 100644
--- a/arch/x86/kernel/cpu/mtrr/generic.c
+++ b/arch/x86/kernel/cpu/mtrr/generic.c
@@ -90,7 +90,7 @@ u8 mtrr_type_lookup(u64 start, u64 end)
 	 * Look of multiple ranges matching this address and pick type
 	 * as per MTRR precedence
 	 */
-	if (!mtrr_state.enabled & 2) {
+	if (!(mtrr_state.enabled & 2)) {
 		return mtrr_state.def_type;
 	}