From: Kirill Korotaev <dev@openvz.org>
Date: Sun, 24 Jun 2007 00:16:51 +0000 (-0700)
Subject: ext4: lost brelse in ext4_read_inode()
X-Git-Tag: v2.6.22-rc6~4
X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=e5d2861f31474b373ce7754dc5122b414a176c64;p=linux-2.6-omap-h63xx.git

ext4: lost brelse in ext4_read_inode()

One of error path in ext4_read_inode() leaks bh since brelse is forgoten.

Signed-off-by: Kirill Korotaev <dev@openvz.org>
Acked-by: Vasily Averin <vvs@sw.ru>
Cc: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
---

diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index 0bcf62a750f..8416fa28c42 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -2673,8 +2673,10 @@ void ext4_read_inode(struct inode * inode)
 		 */
 		ei->i_extra_isize = le16_to_cpu(raw_inode->i_extra_isize);
 		if (EXT4_GOOD_OLD_INODE_SIZE + ei->i_extra_isize >
-		    EXT4_INODE_SIZE(inode->i_sb))
+		    EXT4_INODE_SIZE(inode->i_sb)) {
+			brelse (bh);
 			goto bad_inode;
+		}
 		if (ei->i_extra_isize == 0) {
 			/* The extra space is currently unused. Use it. */
 			ei->i_extra_isize = sizeof(struct ext4_inode) -