From: Michal Sojka <sojkam1@fel.cvut.cz>
Date: Wed, 14 Jan 2009 13:02:38 +0000 (+0100)
Subject: sata_fsl: Return non-zero on error in probe()
X-Git-Tag: v2.6.29-rc2~5^2
X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=e4ac522bd7261829197a3d01d5feedb2aca8ae38;p=linux-2.6-omap-h63xx.git

sata_fsl: Return non-zero on error in probe()

while I was looking over kernel sources I've found this small bug.

Formerly, zero was returned even if an error happened.

Signed-off-by: Michal Sojka <sojkam1@fel.cvut.cz>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
---

diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_fsl.c
index 1a56db92ff7..55bc88c1707 100644
--- a/drivers/ata/sata_fsl.c
+++ b/drivers/ata/sata_fsl.c
@@ -1288,7 +1288,7 @@ static const struct ata_port_info sata_fsl_port_info[] = {
 static int sata_fsl_probe(struct of_device *ofdev,
 			const struct of_device_id *match)
 {
-	int retval = 0;
+	int retval = -ENXIO;
 	void __iomem *hcr_base = NULL;
 	void __iomem *ssr_base = NULL;
 	void __iomem *csr_base = NULL;