From: Stephen Hemminger Date: Fri, 11 May 2007 18:21:45 +0000 (-0700) Subject: skge: crash on shutdown/suspend X-Git-Tag: v2.6.22-rc1~20^2~4 X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=e3b7df17c8344fbcc00e871e03f5f88d58905277;p=linux-2.6-omap-h63xx.git skge: crash on shutdown/suspend If device is not fails during module startup (like unsupported chip version) then driver would crash dereferencing a null pointer, on shutdown or suspend/resume. Signed-off-by: Stephen Hemminger Signed-off-by: Jeff Garzik --- diff --git a/drivers/net/skge.c b/drivers/net/skge.c index e0489578945..77669294656 100644 --- a/drivers/net/skge.c +++ b/drivers/net/skge.c @@ -3802,6 +3802,9 @@ static int skge_suspend(struct pci_dev *pdev, pm_message_t state) struct skge_hw *hw = pci_get_drvdata(pdev); int i, err, wol = 0; + if (!hw) + return 0; + err = pci_save_state(pdev); if (err) return err; @@ -3830,6 +3833,9 @@ static int skge_resume(struct pci_dev *pdev) struct skge_hw *hw = pci_get_drvdata(pdev); int i, err; + if (!hw) + return 0; + err = pci_set_power_state(pdev, PCI_D0); if (err) goto out; @@ -3868,6 +3874,9 @@ static void skge_shutdown(struct pci_dev *pdev) struct skge_hw *hw = pci_get_drvdata(pdev); int i, wol = 0; + if (!hw) + return; + for (i = 0; i < hw->ports; i++) { struct net_device *dev = hw->dev[i]; struct skge_port *skge = netdev_priv(dev);