From: Mark Brown <broonie@sirena.org.uk>
Date: Wed, 23 Apr 2008 09:28:18 +0000 (+0100)
Subject: [ARM] 5017/1: pxa3xx: Report unsupported wakeup sources in pxa3xx_set_wake()
X-Git-Tag: v2.6.26-rc1~351^2~1^2~1
X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=e12177073f28419f1f7eb8dbb93aab6b712c7c04;p=linux-2.6-omap-h63xx.git

[ARM] 5017/1: pxa3xx: Report unsupported wakeup sources in pxa3xx_set_wake()

pxa3xx_set_wake() silently accepts unsupported wake sources, causing
users to believe that they have succesfully configured sources that they
haven't.  Fail the operation instead.

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Acked-by: eric miao <eric.y.miao@gmail.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
---

diff --git a/arch/arm/mach-pxa/pxa3xx.c b/arch/arm/mach-pxa/pxa3xx.c
index dde355e88fa..b6a6f5fcc77 100644
--- a/arch/arm/mach-pxa/pxa3xx.c
+++ b/arch/arm/mach-pxa/pxa3xx.c
@@ -486,6 +486,8 @@ static int pxa3xx_set_wake(unsigned int irq, unsigned int on)
 	case IRQ_MMC3:
 		mask = ADXER_MFP_GEN12;
 		break;
+	default:
+		return -EINVAL;
 	}
 
 	local_irq_save(flags);