From: Kristen Accardi Date: Fri, 9 Mar 2007 23:15:33 +0000 (-0500) Subject: libata-acpi: allow _GTF on SATA, but disable on PATA for now X-Git-Tag: v2.6.21-rc4~58^2 X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=df33c77e3981e71afc8727ee5c432ba1a1bba68c;p=linux-2.6-omap-h63xx.git libata-acpi: allow _GTF on SATA, but disable on PATA for now The ACPI specification states, and BIOS implementations depend on, _STM being called before _GTF. SATA does this, but PATA does not. So for now, simply prevent execution of _GTF on PATA devices. Longer term we should implement ACPI support for PATA devices in libata. Signed-off-by: Kristen Accardi Signed-off-by: Len Brown --- diff --git a/drivers/ata/libata-acpi.c b/drivers/ata/libata-acpi.c index d14a48e75f1..89aaf749cd1 100644 --- a/drivers/ata/libata-acpi.c +++ b/drivers/ata/libata-acpi.c @@ -561,6 +561,13 @@ int ata_acpi_exec_tfs(struct ata_port *ap) if (noacpi) return 0; + /* + * TBD - implement PATA support. For now, + * we should not run GTF on PATA devices since some + * PATA require execution of GTM/STM before GTF. + */ + if (!(ap->cbl == ATA_CBL_SATA)) + return 0; for (ix = 0; ix < ATA_MAX_DEVICES; ix++) { if (!ata_dev_enabled(&ap->device[ix]))