From: Ingo Molnar <mingo@elte.hu>
Date: Wed, 26 Nov 2008 00:50:02 +0000 (-0800)
Subject: pkt_sched: fix warning in net/sched/sch_hfsc.c
X-Git-Tag: v2.6.29-rc1~581^2~475
X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=dc0a0011cfa8ff01b86859006f4db3656c9a896b;p=linux-2.6-omap-h63xx.git

pkt_sched: fix warning in net/sched/sch_hfsc.c

this warning:

  net/sched/sch_hfsc.c: In function ‘hfsc_enqueue’:
  net/sched/sch_hfsc.c:1577: warning: ‘err’ may be used uninitialized in this function

triggers because GCC does not recognize the (correct) error flow
between hfsc_classify(), 'cl' and 'err'.

Annotate it.

Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/sched/sch_hfsc.c b/net/sched/sch_hfsc.c
index 51dd3f40162..613179c9969 100644
--- a/net/sched/sch_hfsc.c
+++ b/net/sched/sch_hfsc.c
@@ -1563,7 +1563,7 @@ static int
 hfsc_enqueue(struct sk_buff *skb, struct Qdisc *sch)
 {
 	struct hfsc_class *cl;
-	int err;
+	int uninitialized_var(err);
 
 	cl = hfsc_classify(skb, sch, &err);
 	if (cl == NULL) {