From: Harvey Harrison <harvey.harrison@gmail.com>
Date: Wed, 22 Oct 2008 03:28:04 +0000 (-0700)
Subject: ALSA: hda - correct bracketing in spdif test in patch_sigmatel.c
X-Git-Tag: v2.6.28-rc1~20^2^4
X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=da74ae3e32374755e0fbdfed4074cf839a82f615;p=linux-2.6-omap-h63xx.git

ALSA: hda - correct bracketing in spdif test in patch_sigmatel.c

Noticed by sparse:
sound/pci/hda/patch_sigmatel.c:1285:43: warning: dubious: !x & y

Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
Acked-by: Matthew Ranostay <mranostay@embeddedalley.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---

diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c
index a2ac7205d45..788fdc6f326 100644
--- a/sound/pci/hda/patch_sigmatel.c
+++ b/sound/pci/hda/patch_sigmatel.c
@@ -1282,7 +1282,7 @@ static int stac92xx_build_controls(struct hda_codec *codec)
 			return err;
 		spec->multiout.share_spdif = 1;
 	}
-	if (spec->dig_in_nid && (!spec->gpio_dir & 0x01)) {
+	if (spec->dig_in_nid && !(spec->gpio_dir & 0x01)) {
 		err = snd_hda_create_spdif_in_ctls(codec, spec->dig_in_nid);
 		if (err < 0)
 			return err;