From: Uwe Kleine-König Date: Sun, 21 Sep 2008 21:52:07 +0000 (+0200) Subject: avr32: Use platform_driver_probe for pio platform driver X-Git-Tag: v2.6.28-rc1~700^2~7 X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=d6634db8fe1784d0a8e4e156970fec034708446e;p=linux-2.6-omap-h63xx.git avr32: Use platform_driver_probe for pio platform driver The probe function of the pio platform driver lives in the init section and so a pio device that is created after the init section is discarded probably results in an oops. Even if this cannot happen, using platform_driver_probe is cleaner. (If this can happen and should be supported the probe function must live in the devinit section instead.) Signed-off-by: Uwe Kleine-König Signed-off-by: Haavard Skinnemoen --- diff --git a/arch/avr32/mach-at32ap/pio.c b/arch/avr32/mach-at32ap/pio.c index 90ef538ae54..ef2561e1539 100644 --- a/arch/avr32/mach-at32ap/pio.c +++ b/arch/avr32/mach-at32ap/pio.c @@ -401,7 +401,6 @@ static int __init pio_probe(struct platform_device *pdev) } static struct platform_driver pio_driver = { - .probe = pio_probe, .driver = { .name = "pio", }, @@ -409,7 +408,7 @@ static struct platform_driver pio_driver = { static int __init pio_init(void) { - return platform_driver_register(&pio_driver); + return platform_driver_probe(&pio_driver, pio_probe); } postcore_initcall(pio_init);