From: Borislav Petkov Date: Sat, 2 Feb 2008 18:56:35 +0000 (+0100) Subject: ide-floppy: report DMA handling in idefloppy_pc_intr() properly X-Git-Tag: v2.6.25-rc1~1068^2~72 X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=d30a7fba4380901b6a33fd798a0d0f9794a70ccc;p=linux-2.6-omap-h63xx.git ide-floppy: report DMA handling in idefloppy_pc_intr() properly Bart: - use 'hwif' instead of 'HWIF(drive)' - minor CodingStyle fixup Signed-off-by: Borislav Petkov Signed-off-by: Bartlomiej Zolnierkiewicz --- diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c index af4b633fa3d..5c32d0cda4a 100644 --- a/drivers/ide/ide-floppy.c +++ b/drivers/ide/ide-floppy.c @@ -532,13 +532,17 @@ static ide_startstop_t idefloppy_pc_intr (ide_drive_t *drive) idefloppy_pc_t *pc = floppy->pc; struct request *rq = pc->rq; unsigned int temp; + int dma_error = 0; u16 bcount; u8 stat, ireason; debug_log("Reached %s interrupt handler\n", __func__); if (test_bit(PC_DMA_IN_PROGRESS, &pc->flags)) { - if (HWIF(drive)->ide_dma_end(drive)) { + dma_error = hwif->ide_dma_end(drive); + if (dma_error) { + printk(KERN_ERR "%s: DMA %s error\n", drive->name, + rq_data_dir(rq) ? "write" : "read"); set_bit(PC_DMA_ERROR, &pc->flags); } else { pc->actually_transferred = pc->request_transfer;