From: Adrian Bunk Date: Fri, 2 Feb 2007 14:29:19 +0000 (+0100) Subject: [MTD] [NAND] Fix an off-by-one in a BUG_ON in CAFÉ ECC correction. X-Git-Tag: v2.6.21-rc1~66^2~21 X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=d24030f0f71390b1a01796d664445352bd403269;p=linux-2.6-omap-h63xx.git [MTD] [NAND] Fix an off-by-one in a BUG_ON in CAFÉ ECC correction. err_pos_lut[4096] of an array with 4096 elements is a bug. Spotted by the Coverity checker. While I was at it, I also converted it to ARRAY_SIZE(). Signed-off-by: Adrian Bunk Signed-off-by: David Woodhouse --- diff --git a/drivers/mtd/nand/cafe_ecc.c b/drivers/mtd/nand/cafe_ecc.c index 1b9fa05a447..ea5c8491d2c 100644 --- a/drivers/mtd/nand/cafe_ecc.c +++ b/drivers/mtd/nand/cafe_ecc.c @@ -1045,7 +1045,7 @@ static unsigned short err_pos_lut[4096] = { static unsigned short err_pos(unsigned short din) { - BUG_ON(din > 4096); + BUG_ON(din >= ARRAY_SIZE(err_pos_lut)); return err_pos_lut[din]; } static int chk_no_err_only(unsigned short *chk_syndrome_list, unsigned short *err_info)