From: Linus Torvalds Date: Tue, 8 Jan 2008 19:46:37 +0000 (-0800) Subject: Revert "hda_intel suspend latency: shorten codec read" X-Git-Tag: v2.6.24-rc8~71 X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=d238998fbfa49f30b02f0a5de5294ca53c58348c;p=linux-2.6-omap-h63xx.git Revert "hda_intel suspend latency: shorten codec read" This reverts commit 57a04513cb35086d54bcb2cb92e6627fc8fa0fae. Harald Dunkel reports that it broke sound for him: "Alsa stopped working for me. I still can access /dev/dsp, change the volume and so on, but the speakers are quiet." Reverting it fixed things for him. Reported-and-tested-by: Harald Dunkel Acked-by: Takashi Iwai Acked-by: Ingo Molnar Signed-off-by: Linus Torvalds --- diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index 62b9fb38690..3fa0f970490 100644 --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -555,8 +555,7 @@ static unsigned int azx_rirb_get_response(struct hda_codec *codec) } if (!chip->rirb.cmds) return chip->rirb.res; /* the last value */ - udelay(10); - cond_resched(); + schedule_timeout_uninterruptible(1); } while (time_after_eq(timeout, jiffies)); if (chip->msi) {