From: Keith Packard Date: Fri, 17 Oct 2008 07:44:42 +0000 (-0700) Subject: i915: Disable MSI on GM965 (errata says it doesn't work) X-Git-Tag: v2.6.28-rc1~28^2~9 X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=d1ed629f44b3a4108d5c445971535f05f441fce7;p=linux-2.6-omap-h63xx.git i915: Disable MSI on GM965 (errata says it doesn't work) Current Intel errata for the GM965 says that using MSI may cause interrupts to be delayed or lost. The only workaround offered is to not use it. Signed-off-by: Keith Packard Signed-off-by: Eric Anholt Signed-off-by: Dave Airlie --- diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c index db34780edbb..01de536e021 100644 --- a/drivers/gpu/drm/i915/i915_dma.c +++ b/drivers/gpu/drm/i915/i915_dma.c @@ -844,8 +844,11 @@ int i915_driver_load(struct drm_device *dev, unsigned long flags) * correctly in testing on 945G. * This may be a side effect of MSI having been made available for PEG * and the registers being closely associated. + * + * According to chipset errata, on the 965GM, MSI interrupts may + * be lost or delayed */ - if (!IS_I945G(dev) && !IS_I945GM(dev)) + if (!IS_I945G(dev) && !IS_I945GM(dev) && !IS_I965GM(dev)) if (pci_enable_msi(dev->pdev)) DRM_ERROR("failed to enable MSI\n");