From: Li Zefan <lizf@cn.fujitsu.com>
Date: Wed, 9 Jan 2008 07:44:44 +0000 (-0800)
Subject: [CONNECTOR]: Don't touch queue dev after decrement of ref count.
X-Git-Tag: v2.6.24-rc8~54^2~2
X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=cf585ae8ae9ac7287a6d078425ea32f22bf7f1f7;p=linux-2.6-omap-h63xx.git

[CONNECTOR]: Don't touch queue dev after decrement of ref count.

cn_queue_free_callback() will touch 'dev'(i.e. cbq->pdev), so it
should be called before atomic_dec(&dev->refcnt).

Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/connector/cn_queue.c b/drivers/connector/cn_queue.c
index 296f51002b5..12ceed54ab1 100644
--- a/drivers/connector/cn_queue.c
+++ b/drivers/connector/cn_queue.c
@@ -99,8 +99,8 @@ int cn_queue_add_callback(struct cn_queue_dev *dev, char *name, struct cb_id *id
 	spin_unlock_bh(&dev->queue_lock);
 
 	if (found) {
-		atomic_dec(&dev->refcnt);
 		cn_queue_free_callback(cbq);
+		atomic_dec(&dev->refcnt);
 		return -EINVAL;
 	}