From: Roel Kluin Date: Tue, 7 Apr 2009 02:00:54 +0000 (-0700) Subject: spi: limit reaches -1, tested 0 X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=c8fc657e6a114fadf78fdf8103e289a169c91c5d;p=linux-2.6-omap-h63xx.git spi: limit reaches -1, tested 0 With a postfix decrement limit will reach -1 rather than 0, so the warning will not be issued. Also, add a cpu_relax() into the busy-wait loop. Signed-off-by: Roel Kluin Cc: Mariusz Ceier Acked-by: David Brownell Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/drivers/spi/spi_imx.c b/drivers/spi/spi_imx.c index 0480d8bb19d..014af69fc1b 100644 --- a/drivers/spi/spi_imx.c +++ b/drivers/spi/spi_imx.c @@ -779,7 +779,8 @@ static irqreturn_t interrupt_transfer(struct driver_data *drv_data) /* Read trailing bytes */ limit = loops_per_jiffy << 1; - while ((read(drv_data) == 0) && limit--); + while ((read(drv_data) == 0) && --limit) + cpu_relax(); if (limit == 0) dev_err(&drv_data->pdev->dev,