From: Eric Dumazet <dada1@cosmosbay.com>
Date: Thu, 30 Oct 2008 21:00:53 +0000 (-0700)
Subject: udp: Should use spin_lock_bh()/spin_unlock_bh() in udp_lib_unhash()
X-Git-Tag: v2.6.29-rc1~581^2~938
X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=c8db3fec5b02f4cefe441903fe1c142ff14e1771;p=linux-2.6-omap-h63xx.git

udp: Should use spin_lock_bh()/spin_unlock_bh() in udp_lib_unhash()

Spotted by Alexander Beregalov

Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c
index c3ecec8a9e1..f760b86e753 100644
--- a/net/ipv4/udp.c
+++ b/net/ipv4/udp.c
@@ -970,12 +970,12 @@ void udp_lib_unhash(struct sock *sk)
 	unsigned int hash = udp_hashfn(sock_net(sk), sk->sk_hash);
 	struct udp_hslot *hslot = &udptable->hash[hash];
 
-	spin_lock(&hslot->lock);
+	spin_lock_bh(&hslot->lock);
 	if (sk_del_node_init_rcu(sk)) {
 		inet_sk(sk)->num = 0;
 		sock_prot_inuse_add(sock_net(sk), sk->sk_prot, -1);
 	}
-	spin_unlock(&hslot->lock);
+	spin_unlock_bh(&hslot->lock);
 }
 EXPORT_SYMBOL(udp_lib_unhash);