From: Linus Torvalds Date: Fri, 9 Jan 2009 20:49:50 +0000 (-0800) Subject: x86: make 'constant_test_bit()' take an unsigned bit number X-Git-Tag: v2.6.29-rc1~29 X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=c4295fbb6048d85f0b41c5ced5cbf63f6811c46c;p=linux-2.6-omap-h63xx.git x86: make 'constant_test_bit()' take an unsigned bit number Ingo noticed that using signed arithmetic seems to confuse the gcc inliner, and make it potentially decide that it's all too complicated. (Yeah, yeah, it's a constant. It's always positive. Still..) Based-on: Ingo Molnar Signed-off-by: Linus Torvalds --- diff --git a/arch/x86/include/asm/bitops.h b/arch/x86/include/asm/bitops.h index 9fa9dcdf344..e02a359d2aa 100644 --- a/arch/x86/include/asm/bitops.h +++ b/arch/x86/include/asm/bitops.h @@ -300,7 +300,7 @@ static inline int test_and_change_bit(int nr, volatile unsigned long *addr) return oldbit; } -static inline int constant_test_bit(int nr, const volatile unsigned long *addr) +static inline int constant_test_bit(unsigned int nr, const volatile unsigned long *addr) { return ((1UL << (nr % BITS_PER_LONG)) & (((unsigned long *)addr)[nr / BITS_PER_LONG])) != 0;