From: Rafael J. Wysocki Date: Thu, 19 Jul 2007 08:47:35 +0000 (-0700) Subject: Freezer: remove redundant check in try_to_freeze_tasks X-Git-Tag: v2.6.23-rc1~456 X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=c2cf7d87d804c66e063829d5ca739053e901dc15;p=linux-2.6-omap-h63xx.git Freezer: remove redundant check in try_to_freeze_tasks We don't need to check if todo is positive before calling time_after() in try_to_freeze_tasks(), because if todo is zero at this point, the loop will be broken anyway due to the while () condition being false. Signed-off-by: Rafael J. Wysocki Acked-by: Pavel Machek Cc: Gautham R Shenoy Cc: Oleg Nesterov Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/kernel/power/process.c b/kernel/power/process.c index 00cdbe5f518..3434940a3df 100644 --- a/kernel/power/process.c +++ b/kernel/power/process.c @@ -149,7 +149,7 @@ static int try_to_freeze_tasks(int freeze_user_space) } while_each_thread(g, p); read_unlock(&tasklist_lock); yield(); /* Yield is okay here */ - if (todo && time_after(jiffies, end_time)) + if (time_after(jiffies, end_time)) break; } while (todo);