From: Anton Vorontsov Date: Fri, 5 Dec 2008 08:15:39 +0000 (+0000) Subject: of: Minor simplification for the of_parse_phandles_with_args() X-Git-Tag: v2.6.29-rc1~574^2~50 X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=c1bb7c6d04ebdf48998649100c5267a9139debf5;p=linux-2.6-omap-h63xx.git of: Minor simplification for the of_parse_phandles_with_args() By using 'list++' in the beginning we can simplify the code a little bit. Suggested-by: Benjamin Herrenschmidt Signed-off-by: Anton Vorontsov Signed-off-by: Paul Mackerras --- diff --git a/drivers/of/base.c b/drivers/of/base.c index 4f884a358a7..cf04d4dd4a5 100644 --- a/drivers/of/base.c +++ b/drivers/of/base.c @@ -547,14 +547,12 @@ int of_parse_phandles_with_args(struct device_node *np, const char *list_name, const u32 *cells; const phandle *phandle; - phandle = list; - args = list + 1; + phandle = list++; + args = list; /* one cell hole in the list = <>; */ - if (!*phandle) { - list++; + if (!*phandle) goto next; - } node = of_find_node_by_phandle(*phandle); if (!node) { @@ -570,8 +568,7 @@ int of_parse_phandles_with_args(struct device_node *np, const char *list_name, goto err1; } - /* Next phandle is at offset of one phandle cell + #cells */ - list += 1 + *cells; + list += *cells; if (list > list_end) { pr_debug("%s: insufficient arguments length\n", np->full_name);