From: Al Viro Date: Sun, 14 Oct 2007 18:20:30 +0000 (+0100) Subject: skb->tail in ibm_newemac should be skb_tail_pointer() X-Git-Tag: v2.6.24-rc1~1322 X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=bef1bc95f32bd7603c3682dbb8695cf4d5841732;p=linux-2.6-omap-h63xx.git skb->tail in ibm_newemac should be skb_tail_pointer() ... since that sucker is not 32bit-only and on 64bit skb->tail is an offset, not a pointer. Signed-off-by: Al Viro Signed-off-by: Linus Torvalds --- diff --git a/drivers/net/ibm_newemac/core.c b/drivers/net/ibm_newemac/core.c index 8ea50096187..7a5aabd01e0 100644 --- a/drivers/net/ibm_newemac/core.c +++ b/drivers/net/ibm_newemac/core.c @@ -1534,7 +1534,7 @@ static inline int emac_rx_sg_append(struct emac_instance *dev, int slot) dev_kfree_skb(dev->rx_sg_skb); dev->rx_sg_skb = NULL; } else { - cacheable_memcpy(dev->rx_sg_skb->tail, + cacheable_memcpy(skb_tail_pointer(dev->rx_sg_skb), dev->rx_skb[slot]->data, len); skb_put(dev->rx_sg_skb, len); emac_recycle_rx_skb(dev, slot, len);