From: Ingo Molnar <mingo@elte.hu>
Date: Wed, 26 Nov 2008 00:49:07 +0000 (-0800)
Subject: qla3xxx: fix warning in drivers/net/qla3xxx.c
X-Git-Tag: v2.6.29-rc1~581^2~477
X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=be5a3c62c805878d67036b4683f09118cab4c9fd;p=linux-2.6-omap-h63xx.git

qla3xxx: fix warning in drivers/net/qla3xxx.c

this warning:

  drivers/net/qla3xxx.c: In function ‘ql3xxx_probe’:
  drivers/net/qla3xxx.c:3912: warning: ‘pci_using_dac’ may be used uninitialized in this function

triggers because GCC does not recognize the (correct) error flow
between 'pci_using_dac' and 'err'.

Annotate it.

Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/net/qla3xxx.c b/drivers/net/qla3xxx.c
index 7671f943974..6b7ed1a5b3b 100644
--- a/drivers/net/qla3xxx.c
+++ b/drivers/net/qla3xxx.c
@@ -3917,7 +3917,7 @@ static int __devinit ql3xxx_probe(struct pci_dev *pdev,
 	struct net_device *ndev = NULL;
 	struct ql3_adapter *qdev = NULL;
 	static int cards_found = 0;
-	int pci_using_dac, err;
+	int uninitialized_var(pci_using_dac), err;
 
 	err = pci_enable_device(pdev);
 	if (err) {