From: Lennert Buytenhek <buytenh@wantstofly.org>
Date: Tue, 18 Nov 2008 04:28:35 +0000 (+0000)
Subject: mv643xx_eth: fix the order of mdiobus_{unregister, free}() calls
X-Git-Tag: v2.6.28-rc6~8^2~8
X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=bcb3336ce4354395e38df7e2da110fca61f86a84;p=linux-2.6-omap-h63xx.git

mv643xx_eth: fix the order of mdiobus_{unregister, free}() calls

Signed-off-by: Lennert Buytenhek <buytenh@marvell.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/net/mv643xx_eth.c b/drivers/net/mv643xx_eth.c
index b9dcdbd369f..baa7e845a01 100644
--- a/drivers/net/mv643xx_eth.c
+++ b/drivers/net/mv643xx_eth.c
@@ -2435,8 +2435,8 @@ static int mv643xx_eth_shared_remove(struct platform_device *pdev)
 	struct mv643xx_eth_shared_platform_data *pd = pdev->dev.platform_data;
 
 	if (pd == NULL || pd->shared_smi == NULL) {
-		mdiobus_free(msp->smi_bus);
 		mdiobus_unregister(msp->smi_bus);
+		mdiobus_free(msp->smi_bus);
 	}
 	if (msp->err_interrupt != NO_IRQ)
 		free_irq(msp->err_interrupt, msp);