From: Roel Kluin Date: Mon, 2 Feb 2009 00:54:19 +0000 (-0800) Subject: Input: pxa930_trkball - fix write timeout handling X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=bc34496d63ec0a669d6825ea42275fd6fcbe9969;p=linux-2.6-omap-h63xx.git Input: pxa930_trkball - fix write timeout handling With a postfix decrement i reaches -1 rather than 0, but after the loop it is tested whether it has become 0. Signed-off-by: Roel Kluin Signed-off-by: Dmitry Torokhov --- diff --git a/drivers/input/mouse/pxa930_trkball.c b/drivers/input/mouse/pxa930_trkball.c index a0f45c4fc19..784be69b711 100644 --- a/drivers/input/mouse/pxa930_trkball.c +++ b/drivers/input/mouse/pxa930_trkball.c @@ -83,7 +83,7 @@ static int write_tbcr(struct pxa930_trkball *trkball, int v) __raw_writel(v, trkball->mmio_base + TBCR); - while (i--) { + while (--i) { if (__raw_readl(trkball->mmio_base + TBCR) == v) break; msleep(1);