From: Pekka Paalanen <pq@iki.fi>
Date: Tue, 16 Sep 2008 18:54:16 +0000 (+0300)
Subject: x86 mmiotrace: fix a rare memory leak
X-Git-Tag: v2.6.28-rc1~78^2~76
X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=bbe5c7830c6dbde58726d44ec0337bc8b2d95d37;p=linux-2.6-omap-h63xx.git

x86 mmiotrace: fix a rare memory leak

Signed-off-by: Pekka Paalanen <pq@iki.fi>
Acked-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---

diff --git a/arch/x86/mm/mmio-mod.c b/arch/x86/mm/mmio-mod.c
index 635b50e8558..754bd1eaf4f 100644
--- a/arch/x86/mm/mmio-mod.c
+++ b/arch/x86/mm/mmio-mod.c
@@ -307,8 +307,10 @@ static void ioremap_trace_core(resource_size_t offset, unsigned long size,
 	map.map_id = trace->id;
 
 	spin_lock_irq(&trace_lock);
-	if (!is_enabled())
+	if (!is_enabled()) {
+		kfree(trace);
 		goto not_enabled;
+	}
 
 	mmio_trace_mapping(&map);
 	list_add_tail(&trace->list, &trace_list);