From: Chuck Lever Date: Mon, 14 Jan 2008 20:11:46 +0000 (-0500) Subject: SUNRPC: rpcb_getport_sync() should use built-in hostname generator X-Git-Tag: v2.6.25-rc1~1146^2~13 X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=b91e101fca70319f9ca839311bceff5f44dfc1ed;p=linux-2.6-omap-h63xx.git SUNRPC: rpcb_getport_sync() should use built-in hostname generator rpc_create() can already fill in the hostname with a string representation of the server's IP address, so remove redundant logic in in rpcb_getport_sync() that does that. Signed-off-by: Chuck Lever Signed-off-by: Trond Myklebust --- diff --git a/net/sunrpc/rpcb_clnt.c b/net/sunrpc/rpcb_clnt.c index a6cd35883fa..8962ac6b4c1 100644 --- a/net/sunrpc/rpcb_clnt.c +++ b/net/sunrpc/rpcb_clnt.c @@ -220,14 +220,12 @@ int rpcb_getport_sync(struct sockaddr_in *sin, __u32 prog, .rpc_resp = &map.r_port, }; struct rpc_clnt *rpcb_clnt; - char hostname[40]; int status; dprintk("RPC: %s(" NIPQUAD_FMT ", %u, %u, %d)\n", __FUNCTION__, NIPQUAD(sin->sin_addr.s_addr), prog, vers, prot); - sprintf(hostname, NIPQUAD_FMT, NIPQUAD(sin->sin_addr.s_addr)); - rpcb_clnt = rpcb_create(hostname, (struct sockaddr *)sin, + rpcb_clnt = rpcb_create(NULL, (struct sockaddr *)sin, sizeof(sin), prot, 2, 0); if (IS_ERR(rpcb_clnt)) return PTR_ERR(rpcb_clnt);