From: Dean Nelson Date: Sat, 18 Oct 2008 23:06:56 +0000 (-0700) Subject: genirq: NULL struct irq_desc's member 'name' in dynamic_irq_cleanup() X-Git-Tag: v2.6.28-rc1~44^2 X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=b6f3b7803a9231eddc36d0a2a6d2d8105ef89344;p=linux-2.6-omap-h63xx.git genirq: NULL struct irq_desc's member 'name' in dynamic_irq_cleanup() If the member 'name' of the irq_desc structure happens to point to a character string that is resident within a kernel module, problems ensue if that module is rmmod'd (at which time dynamic_irq_cleanup() is called) and then later show_interrupts() is called by someone. It is also not a good thing if the character string resided in kmalloc'd space that has been kfree'd (after having called dynamic_irq_cleanup()). dynamic_irq_cleanup() fails to NULL the 'name' member and show_interrupts() references it on a few architectures (like h8300, sh and x86). Signed-off-by: Dean Nelson Signed-off-by: Ingo Molnar Signed-off-by: Andrew Morton Signed-off-by: Ingo Molnar --- diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c index 3de6ea3ee74..10b5092e9bf 100644 --- a/kernel/irq/chip.c +++ b/kernel/irq/chip.c @@ -76,6 +76,7 @@ void dynamic_irq_cleanup(unsigned int irq) desc->chip_data = NULL; desc->handle_irq = handle_bad_irq; desc->chip = &no_irq_chip; + desc->name = NULL; spin_unlock_irqrestore(&desc->lock, flags); }