From: Pavel Emelyanov Date: Sun, 13 Apr 2008 01:33:50 +0000 (-0700) Subject: [AX25]: Potential ax25_uid_assoc-s leaks on module unload. X-Git-Tag: v2.6.25~33^2~19 X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=ae1b6a31b1f9ef2c7ba5ef89799f210a9ba6937c;p=linux-2.6-omap-h63xx.git [AX25]: Potential ax25_uid_assoc-s leaks on module unload. The ax25_uid_free call walks the ax25_uid_list and releases entries from it. The problem is that after the fisrt call to hlist_del_init the hlist_for_each_entry (which hides behind the ax25_uid_for_each) will consider the current position to be the last and will return. Thus, the whole list will be left not freed. Signed-off-by: Pavel Emelyanov Signed-off-by: David S. Miller --- diff --git a/net/ax25/ax25_uid.c b/net/ax25/ax25_uid.c index 5f4eb73fb9d..57aeba729ba 100644 --- a/net/ax25/ax25_uid.c +++ b/net/ax25/ax25_uid.c @@ -218,9 +218,11 @@ void __exit ax25_uid_free(void) struct hlist_node *node; write_lock(&ax25_uid_lock); +again: ax25_uid_for_each(ax25_uid, node, &ax25_uid_list) { hlist_del_init(&ax25_uid->uid_node); ax25_uid_put(ax25_uid); + goto again; } write_unlock(&ax25_uid_lock); }