From: Jens Axboe Date: Wed, 17 Oct 2007 17:33:05 +0000 (+0200) Subject: Revert "[SCSI] Remove full sg table memset()" X-Git-Tag: v2.6.24-rc1~477^2~1 X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=a3bec5c5aea0da263111c4d8f8eabc1f8560d7bf;p=linux-2.6-omap-h63xx.git Revert "[SCSI] Remove full sg table memset()" A bit too eager - we definitely need to clear the sg table initially, so that we don't accidentally have ->page & 0x01 true and think that is a chain pointer. This reverts commit f5c0dde4c66421a3a2d7d6fa604a712c9b0744e5. --- diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c index 0c86be71bb3..aac8a02cbe8 100644 --- a/drivers/scsi/scsi_lib.c +++ b/drivers/scsi/scsi_lib.c @@ -764,6 +764,8 @@ struct scatterlist *scsi_alloc_sgtable(struct scsi_cmnd *cmd, gfp_t gfp_mask) if (unlikely(!sgl)) goto enomem; + memset(sgl, 0, sizeof(*sgl) * sgp->size); + /* * first loop through, set initial index and return value */