From: Yinghai Lu Date: Wed, 30 Jan 2008 12:33:09 +0000 (+0100) Subject: x86: cleanup setup_node_zones called by paging_init() X-Git-Tag: v2.6.25-rc1~1143^2~304 X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=a261670aed2b5b77a20ce9b15fed57abeb126c0e;p=linux-2.6-omap-h63xx.git x86: cleanup setup_node_zones called by paging_init() setup_node_zones() calcuates some variables but only use them when FLAT_NODE_MEM_MAP is set so change the MACRO postion to avoid calculating. also change it to static, and rename it to flat_setup_node_zones(). Signed-off-by: Yinghai Lu Signed-off-by: Ingo Molnar Signed-off-by: Thomas Gleixner --- diff --git a/arch/x86/mm/numa_64.c b/arch/x86/mm/numa_64.c index 84823148161..551e3590e5c 100644 --- a/arch/x86/mm/numa_64.c +++ b/arch/x86/mm/numa_64.c @@ -233,8 +233,9 @@ void __init setup_node_bootmem(int nodeid, unsigned long start, node_set_online(nodeid); } +#ifdef CONFIG_FLAT_NODE_MEM_MAP /* Initialize final allocator for a zone */ -void __init setup_node_zones(int nodeid) +static void __init flat_setup_node_zones(int nodeid) { unsigned long start_pfn, end_pfn, memmapsize, limit; @@ -250,14 +251,16 @@ void __init setup_node_zones(int nodeid) */ memmapsize = sizeof(struct page) * (end_pfn-start_pfn); limit = end_pfn << PAGE_SHIFT; -#ifdef CONFIG_FLAT_NODE_MEM_MAP + NODE_DATA(nodeid)->node_mem_map = __alloc_bootmem_core(NODE_DATA(nodeid)->bdata, memmapsize, SMP_CACHE_BYTES, round_down(limit - memmapsize, PAGE_SIZE), limit); -#endif } +#else +#define flat_setup_node_zones(i) do {} while (0) +#endif /* * There are unfortunately some poorly designed mainboards around that @@ -581,7 +584,7 @@ void __init paging_init(void) sparse_init(); for_each_online_node(i) - setup_node_zones(i); + flat_setup_node_zones(i); free_area_init_nodes(max_zone_pfns); }