From: Jiri Slaby <jirislaby@gmail.com>
Date: Wed, 11 Mar 2009 20:47:39 +0000 (+0100)
Subject: USB: misc/vstusb, fix lock imbalance
X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=a08b43aee46ed4272ad7bee2c785edcf313339b3;p=linux-2.6-omap-h63xx.git

USB: misc/vstusb, fix lock imbalance

Make sure we don't leak locked vstdev->lock in vstusb_write. Unlock
properly on one fail path.

Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---

diff --git a/drivers/usb/misc/vstusb.c b/drivers/usb/misc/vstusb.c
index 63dff9ba73c..f26ea8dc157 100644
--- a/drivers/usb/misc/vstusb.c
+++ b/drivers/usb/misc/vstusb.c
@@ -401,6 +401,7 @@ static ssize_t vstusb_write(struct file *file, const char __user *buffer,
 	}
 
 	if (copy_from_user(buf, buffer, count)) {
+		mutex_unlock(&vstdev->lock);
 		dev_err(&dev->dev, "%s: can't copy_from_user\n", __func__);
 		retval = -EFAULT;
 		goto exit;