From: Patrick McHardy Date: Fri, 30 Nov 2007 12:58:03 +0000 (+1100) Subject: [NETFILTER]: xt_TCPMSS: remove network triggerable WARN_ON X-Git-Tag: v2.6.24-rc4~8^2~4 X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=9dc0564e862b1b9a4677dec2c736b12169e03e99;p=linux-2.6-omap-h63xx.git [NETFILTER]: xt_TCPMSS: remove network triggerable WARN_ON ipv6_skip_exthdr() returns -1 for invalid packets. don't WARN_ON that. Signed-off-by: Patrick McHardy Signed-off-by: Herbert Xu --- diff --git a/net/netfilter/xt_TCPMSS.c b/net/netfilter/xt_TCPMSS.c index 07435a602b1..8e76d1f52fb 100644 --- a/net/netfilter/xt_TCPMSS.c +++ b/net/netfilter/xt_TCPMSS.c @@ -174,10 +174,8 @@ xt_tcpmss_target6(struct sk_buff *skb, nexthdr = ipv6h->nexthdr; tcphoff = ipv6_skip_exthdr(skb, sizeof(*ipv6h), &nexthdr); - if (tcphoff < 0) { - WARN_ON(1); + if (tcphoff < 0) return NF_DROP; - } ret = tcpmss_mangle_packet(skb, targinfo, tcphoff, sizeof(*ipv6h) + sizeof(struct tcphdr)); if (ret < 0)