From: Andrew Vasquez Date: Wed, 23 Aug 2006 21:54:54 +0000 (-0700) Subject: [SCSI] qla2xxx: Correct PLOGI retry logic. X-Git-Tag: v2.6.18-rc5~57^2~3 X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=9c06938aa458843fb71fa35371f23a3b89317252;p=linux-2.6-omap-h63xx.git [SCSI] qla2xxx: Correct PLOGI retry logic. Original code attempts to retry PLOGIs to fcports that are FCP_TARGETs only. If the driver never performed a successful PLOGI/PRLI, the port-type would never be assigned, and the relogin logic would silently drop the request (and thus the port would not be recognized and registered). The fix is relatively straightforward, drop the FCP_TARGET-only check. Signed-off-by: Andrew Vasquez Signed-off-by: James Bottomley --- diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c index 1e2b95bac83..65cbe2f5eea 100644 --- a/drivers/scsi/qla2xxx/qla_os.c +++ b/drivers/scsi/qla2xxx/qla_os.c @@ -2238,9 +2238,6 @@ qla2x00_do_dpc(void *data) next_loopid = 0; list_for_each_entry(fcport, &ha->fcports, list) { - if (fcport->port_type != FCT_TARGET) - continue; - /* * If the port is not ONLINE then try to login * to it if we haven't run out of retries.