From: Ilpo Järvinen Date: Fri, 20 Feb 2009 23:38:45 +0000 (-0800) Subject: sx.c: fix dbl statement if - add missing braces X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=9b6d25100ace1dcf9750803ff08f6b61f840be79;p=linux-2.6-omap-h63xx.git sx.c: fix dbl statement if - add missing braces Caused by 736d54533aed (sx.c: fix missed unlock_kernel() on error path in sx_fw_ioctl()). You guys keep breaking things this way in every single kernel release in at least couple of places... :-( Signed-off-by: Ilpo Järvinen Acked-by: Dan Carpenter Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/drivers/char/sx.c b/drivers/char/sx.c index f146e90404f..d7c416566bd 100644 --- a/drivers/char/sx.c +++ b/drivers/char/sx.c @@ -1746,9 +1746,10 @@ static long sx_fw_ioctl(struct file *filp, unsigned int cmd, sx_dprintk(SX_DEBUG_FIRMWARE, "returning type= %ld\n", rc); break; case SXIO_DO_RAMTEST: - if (sx_initialized) /* Already initialized: better not ramtest the board. */ + if (sx_initialized) { /* Already initialized: better not ramtest the board. */ rc = -EPERM; break; + } if (IS_SX_BOARD(board)) { rc = do_memtest(board, 0, 0x7000); if (!rc)