From: Andrew Morton Date: Wed, 17 Oct 2007 06:30:33 +0000 (-0700) Subject: writeback: fix time ordering of the per superblock dirty inode lists: memory-backed... X-Git-Tag: v2.6.24-rc1~576 X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=9852a0e76cd9c89e71f84e784212fdd7a97ae93a;p=linux-2.6-omap-h63xx.git writeback: fix time ordering of the per superblock dirty inode lists: memory-backed inodes For reasons which escape me, inodes which are dirty against a ram-backed filesystem are managed in the same way as inodes which are backed by real devices. Probably we could optimise things here. But given that we skip the entire supeblock as son as we hit the first dirty inode, there's not a lot to be gained. And the code does need to handle one particular non-backed superblock: the kernel's fake internal superblock which holds all the blockdevs. Still. At present when the code encounters an inode which is dirty against a memory-backed filesystem it will skip that inode by refiling it back onto s_dirty. But it fails to update the inode's timestamp when doing so which at least makes the debugging code upset. Fix. Cc: Mike Waychison Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c index 08b9f83b645..f8618e0bb62 100644 --- a/fs/fs-writeback.c +++ b/fs/fs-writeback.c @@ -354,7 +354,7 @@ sync_sb_inodes(struct super_block *sb, struct writeback_control *wbc) long pages_skipped; if (!bdi_cap_writeback_dirty(bdi)) { - list_move(&inode->i_list, &sb->s_dirty); + redirty_tail(inode); if (sb_is_blkdev_sb(sb)) { /* * Dirty memory-backed blockdev: the ramdisk